Skip to content

ref(flags): Move 2 should-be-permanent flags to permanent.py #114934

Merged
wedamija merged 2 commits intomasterfrom
flag-cleanup/should-be-permanent-batch
May 6, 2026
Merged

ref(flags): Move 2 should-be-permanent flags to permanent.py #114934
wedamija merged 2 commits intomasterfrom
flag-cleanup/should-be-permanent-batch

Conversation

@wedamija
Copy link
Copy Markdown
Member

@wedamija wedamija commented May 5, 2026

Per the flag scanner, these flags use the INTERNAL strategy with no
flagpole config and are subscription-managed (granted via plan
handlers / feature lists), so they belong in permanent.py rather than
temporary.py. Pure registration move — no behavior change.

  • auth:register
  • organizations:continuous-profiling-stats

wedamija and others added 2 commits May 5, 2026 16:26
Per the flag scanner, these flags use the INTERNAL strategy with no
flagpole config and are subscription-managed (granted via plan
handlers / feature lists), so they belong in permanent.py rather than
temporary.py. Pure registration move — no behavior change.

- auth:register
- organizations:continuous-profiling-stats

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Mirror the org/project pattern for system-scoped permanent flags so
adding new ones is a one-line dict edit instead of an ad-hoc
manager.add() block. Consolidates the existing auth:register and
system:multi-region registrations into the new dict.

Note: SystemFeatures cannot be flagpole-controlled (flagpole only
handles org/project scope), so the loop hardcodes
FeatureHandlerStrategy.INTERNAL.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@wedamija wedamija requested a review from a team May 5, 2026 23:28
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 5, 2026
Comment thread src/sentry/features/permanent.py
Copy link
Copy Markdown
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The default value of api_expose is false so warden comment is not relevant.

@wedamija wedamija merged commit 3779bf8 into master May 6, 2026
83 checks passed
@wedamija wedamija deleted the flag-cleanup/should-be-permanent-batch branch May 6, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants