ref(flags): Move 2 should-be-permanent flags to permanent.py #114934
Merged
ref(flags): Move 2 should-be-permanent flags to permanent.py #114934
Conversation
Per the flag scanner, these flags use the INTERNAL strategy with no flagpole config and are subscription-managed (granted via plan handlers / feature lists), so they belong in permanent.py rather than temporary.py. Pure registration move — no behavior change. - auth:register - organizations:continuous-profiling-stats Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Mirror the org/project pattern for system-scoped permanent flags so adding new ones is a one-line dict edit instead of an ad-hoc manager.add() block. Consolidates the existing auth:register and system:multi-region registrations into the new dict. Note: SystemFeatures cannot be flagpole-controlled (flagpole only handles org/project scope), so the loop hardcodes FeatureHandlerStrategy.INTERNAL. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
markstory
approved these changes
May 6, 2026
Member
markstory
left a comment
There was a problem hiding this comment.
Looks good. The default value of api_expose is false so warden comment is not relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the flag scanner, these flags use the INTERNAL strategy with no
flagpole config and are subscription-managed (granted via plan
handlers / feature lists), so they belong in permanent.py rather than
temporary.py. Pure registration move — no behavior change.